luoyuxia commented on a change in pull request #16417:
URL: https://github.com/apache/flink/pull/16417#discussion_r666020950



##########
File path: 
flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/internals/KafkaTopicsDescriptor.java
##########
@@ -51,8 +50,19 @@ public KafkaTopicsDescriptor(
             checkArgument(
                     !fixedTopics.isEmpty(),
                     "If subscribing to a fixed topics list, the supplied list 
cannot be empty.");
+            fixedTopics.forEach(
+                    topic -> {
+                        checkArgument(
+                                
!org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly(topic),

Review comment:
       Sorry for the misleading, we don't need to specific 
org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly, we can just import 
org.apache.flink.util.StringUtils and use  StringUtils.isNullOrWhitespaceOnly 
here.
   
   The reason we need to specific 
org.apache.flink.util.StringUtils.isNullOrWhitespaceOnly in class 
FlinkKafkaProducer.java is that we have imported 
org.apache.commons.lang3.StringUtils.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to