dawidwys commented on a change in pull request #16415:
URL: https://github.com/apache/flink/pull/16415#discussion_r666074595
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/streaming/api/FileReadingWatermarkITCase.java
##########
@@ -62,8 +64,17 @@ public void testWatermarkEmissionWithChaining() throws
Exception {
JobExecutionResult result = env.execute();
int actual = result.getAccumulatorResult(NUM_WATERMARKS_ACC_NAME);
-
- assertTrue("too few watermarks emitted: " + actual, actual >=
MIN_EXPECTED_WATERMARKS);
+ long expected =
+ result.<Long>getAccumulatorResult(RUNTIME_ACC_NAME) /
WATERMARK_INTERVAL_MILLIS;
+ checkState(expected > MIN_EXPECTED_WATERMARKS);
+
+ assertEquals(
+ "too few watermarks emitted in "
+ + result.<Long>getAccumulatorResult(RUNTIME_ACC_NAME)
+ + " ms",
+ expected,
+ actual,
+ .5 * expected);
Review comment:
Yeah, that's the sentiment that I am getting from the test. We just hope
it works. ;)
Would simplifying the test to check if there was at least a single watermark
made the test useless? Or would it basically check the same thing? I also don't
get the comment on the class:
> * Tests that watermarks are emitted while file is being read,
particularly the last split.
How does it test emitting watermarks from the last split?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
