gaoyunhaii commented on a change in pull request #16432:
URL: https://github.com/apache/flink/pull/16432#discussion_r666637899
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/util/IncompleteFuturesTracker.java
##########
@@ -108,4 +94,22 @@ void removeFromSet(CompletableFuture<?> future) {
lock.unlock();
}
}
+
+ @VisibleForTesting
+ Collection<CompletableFuture<?>> getCurrentIncomplete() {
Review comment:
Sorry here I made a mistake that I initially want to make this method a
pure getter one without modifying the state, and it would be only used in the
tests for the verification. Do you think this would be also ok that I remove
`incompleteFutures.clear()` and keep the name as `getCurrentIncomplete()` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
