AHeise commented on a change in pull request #16345: URL: https://github.com/apache/flink/pull/16345#discussion_r666701426
########## File path: flink-core/src/main/java/org/apache/flink/core/classloading/ComponentClassLoader.java ########## @@ -0,0 +1,246 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.classloading; + +import org.apache.flink.util.function.FunctionWithException; + +import org.apache.flink.shaded.guava18.com.google.common.collect.Iterators; + +import java.io.IOException; +import java.net.URL; +import java.net.URLClassLoader; +import java.util.Arrays; +import java.util.Enumeration; +import java.util.Iterator; + +/** + * A {@link URLClassLoader} that restricts which classes can be loaded to those contained within the + * given classpath, except classes from a given set of packages that are either loaded parent or + * child-first. + */ +public class ComponentClassLoader extends URLClassLoader { Review comment: I like the current abstraction of having a basic class loader and then the specialized classloaders. This would eventually give us the opportunity to change the behavior of the subclasses without breaking code. Do you envision that this class is used directly? If not, do you want to guard against that (docs, visibility, or abstract)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
