[ 
https://issues.apache.org/jira/browse/FLINK-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephan Ewen updated FLINK-3995:
--------------------------------
    Description: 
All valuable test utils are only found in {{test-jars}}, but should be found in 
the {{compile}} scope of the test util projects.
  - TestLogger
  - RetryRules
  - MiniClusters
  - TestEnvironments
  - ...

Additionally, we have dependencies where the {{compile}} scope of some projects 
depends on {{test-jars}} of other projects. That can create problems in some 
builds and with some tools.

Here is how we can fix that:

  - Create a {{flink-testutils-core}} project, which has the test utils 
currently contained in the {{flink-core}} {{test-jar}} in the main scope. That 
means the {{flink-core test-jar}} is not needed by other projects any more.
  - Make the Mini Cluster available in {{flink-test-utils}} main scope.
  - To remove the test-jar dependency on {{flink-runtime}} from the 
{{flink-test-utils}} project, we need to move the test actor classes to the 
main scope in {{flink-runtime}}.

This is related to FLINK-1827 (a followup).


  was:
We currently have the problem that valuable test utils are only found in test 
jars:
  - TestLogger
  - RetryRules
  - MiniClusters
  - TestEnvironments
  - ...

In addition, this created a strange setup where the {{compile}} scope of some 
projects depends on the {{test-jar}} of other projects.

To make things clean and let users use the {{flink-test-utils}} main scope (not 
test jar) properly, I suggest the following:

  - Create a {{flink-testutils-core}} project, which has the test utils 
currently contained in the {{flink-core}} {{test-jar}} in the main scope.
  - Make the Mini Cluster available in {{flink-test-utils}} main scope.
  - To remove the test-jar dependency on {{flink-runtime}} from the 
{{flink-test-utils}} project, we need to move the test actor classes to the 
main scope in {{flink-runtime}}.


This is related to FLINK-1827 (a followup).



> Properly Structure Test Utils and Dependencies
> ----------------------------------------------
>
>                 Key: FLINK-3995
>                 URL: https://issues.apache.org/jira/browse/FLINK-3995
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.0.2
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>             Fix For: 1.1.0
>
>
> All valuable test utils are only found in {{test-jars}}, but should be found 
> in the {{compile}} scope of the test util projects.
>   - TestLogger
>   - RetryRules
>   - MiniClusters
>   - TestEnvironments
>   - ...
> Additionally, we have dependencies where the {{compile}} scope of some 
> projects depends on {{test-jars}} of other projects. That can create problems 
> in some builds and with some tools.
> Here is how we can fix that:
>   - Create a {{flink-testutils-core}} project, which has the test utils 
> currently contained in the {{flink-core}} {{test-jar}} in the main scope. 
> That means the {{flink-core test-jar}} is not needed by other projects any 
> more.
>   - Make the Mini Cluster available in {{flink-test-utils}} main scope.
>   - To remove the test-jar dependency on {{flink-runtime}} from the 
> {{flink-test-utils}} project, we need to move the test actor classes to the 
> main scope in {{flink-runtime}}.
> This is related to FLINK-1827 (a followup).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to