zentol commented on a change in pull request #95:
URL: https://github.com/apache/flink-shaded/pull/95#discussion_r666798074
##########
File path: flink-shaded-netty-tcnative-dynamic/pom.xml
##########
@@ -146,27 +147,18 @@ under the License.
<echo message="extracting netty_tcnative
dynamically linked wrapper libraries" />
<!-- Fix the dynamically linked native
libraries in netty-tcnative -->
<unzip
src="${project.build.directory}/native_libs/netty-tcnative-${netty.tcnative.version}-linux-x86_64.jar"
dest="${project.build.directory}/native_libs/unpacked/" />
- <move
todir="${project.build.directory}/unpacked/META-INF/native"
includeemptydirs="false">
- <fileset
dir="${project.build.directory}/native_libs/unpacked/META-INF/native"/>
- <mapper type="glob"
from="libnetty_tcnative.so"
to="liborg_apache_flink_shaded_netty4_netty_tcnative_linux_x86_64.so"/>
- </move>
- <delete
dir="${project.build.directory}/native_libs/unpacked/" />
- <unzip
src="${project.build.directory}/native_libs/netty-tcnative-${netty.tcnative.version}-linux-x86_64-fedora.jar"
dest="${project.build.directory}/native_libs/unpacked/" />
- <move
todir="${project.build.directory}/unpacked/META-INF/native"
includeemptydirs="false">
- <fileset
dir="${project.build.directory}/native_libs/unpacked/META-INF/native"/>
- <mapper type="glob"
from="libnetty_tcnative.so"
to="liborg_apache_flink_shaded_netty4_netty_tcnative_linux_x86_64_fedora.so"/>
- </move>
- <delete
dir="${project.build.directory}/native_libs/unpacked/" />
<unzip
src="${project.build.directory}/native_libs/netty-tcnative-${netty.tcnative.version}-osx-x86_64.jar"
dest="${project.build.directory}/native_libs/unpacked/" />
+ <unzip
src="${project.build.directory}/native_libs/netty-tcnative-${netty.tcnative.version}-linux-aarch_64-fedora.jar"
dest="${project.build.directory}/native_libs/unpacked/" />
<move
todir="${project.build.directory}/unpacked/META-INF/native"
includeemptydirs="false">
<fileset
dir="${project.build.directory}/native_libs/unpacked/META-INF/native"/>
- <mapper type="glob"
from="libnetty_tcnative.jnilib"
to="liborg_apache_flink_shaded_netty4_netty_tcnative_osx_x86_64.jnilib"/>
+ <mapper type="glob" from="lib*"
to="liborg_apache_flink_shaded_netty4_*"/>
</move>
<delete
dir="${project.build.directory}/native_libs/unpacked/" />
- <unzip
src="${project.build.directory}/native_libs/netty-tcnative-${netty.tcnative.version}-windows-x86_64.jar"
dest="${project.build.directory}/native_libs/unpacked/" />
+ <!-- the fedora linux .so file has the same
name as the one for plain linux, so we need to separately extract, relocate and
copy it -->
Review comment:
```suggestion
<!-- the fedora linux .so file has the same
name as the one for plain linux, so we need to separately extract, relocate and
move it -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
