gaoyunhaii commented on pull request #16432: URL: https://github.com/apache/flink/pull/16432#issuecomment-877210956
Hi @tillrohrmann sorry for I should have misunderstood the implementation of `completeCheckpointOnceEventsAreDone`, it should only register a callback instead of doing a blocked waiting. Very sorry for the misleading. Then it seems indeed also ok to make the checkpoint future waiting on the failure handling future: Since there won't be concurrent checkpoint triggers, thus no new checkpoint would arrive before the pending checkpoint finished; and it should also be ok to delay the checkpoint for a bit while to wait for failing the subtask. This method seems to be simpler based on the current implementation, and do you prefer to this method~? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
