[ 
https://issues.apache.org/jira/browse/FLINK-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15307951#comment-15307951
 ] 

ASF GitHub Bot commented on FLINK-2314:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2020#discussion_r65209503
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
 ---
    @@ -897,21 +900,21 @@ public TimeCharacteristic 
getStreamTimeCharacteristic() {
         *              The mode in which the source should operate, i.e. 
monitor path and react to new data, or process once and exit
         * @return The DataStream containing the given directory.
         */
    -   public DataStream<String> readFileStream(String filePath, long 
intervalMillis, WatchType watchType) {
    +   public DataStream<String> readTextFile(String filePath, ProcessingMode 
watchType, long intervalMillis) {
                Preconditions.checkNotNull(filePath, "The file path may not be 
null.");
     
                TextInputFormat format = new TextInputFormat(new 
Path(filePath));
    -           return readFile(format, filePath, watchType, intervalMillis);
    +           return readFile(format, filePath, watchType, intervalMillis, 
FilePathFilter.DefaultFilter.getInstance());
        }
     
        /**
         * Reads the given file line-by-line and creates a data stream that 
contains a string with the contents of each such
         * line. The file will be read with the system's default character set.
         *
         * <p>
    -    * <b> NOTES ON CHECKPOINTING: </b> The source (which executes the 
{@link FileSplitMonitoringFunction})
    +    * <b> NOTES ON CHECKPOINTING: </b> The source (which executes the 
{@link ContinuousFileMonitoringFunction})
    --- End diff --
    
    Same as above, and in the javadoc below.


> Make Streaming File Sources Persistent
> --------------------------------------
>
>                 Key: FLINK-2314
>                 URL: https://issues.apache.org/jira/browse/FLINK-2314
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>    Affects Versions: 0.9
>            Reporter: Stephan Ewen
>            Assignee: Kostas Kloudas
>
> Streaming File sources should participate in the checkpointing. They should 
> track the bytes they read from the file and checkpoint it.
> One can look at the sequence generating source function for an example of a 
> checkpointed source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to