cmick opened a new pull request #16472:
URL: https://github.com/apache/flink/pull/16472
## What is the purpose of the change
This pull request fixes the issue described in FLINK-23183. Currently the
redelivered messages are not acknowledged properly upon connection failure
(only applicable when autoAck is disabled). When used with a prefetch count in
the consumer it may even lead to blocking the source from consuming any more
messages.
In the suggested fix, all successfully consumed RMQ messages are be
acknowledged, regardless of whether the message is ignored or processed further
in the pipeline. In case of redelivered messages, `basicReject` is invoked to
acknowledge the message immediately after it's received.
## Brief change log
- `channel.basicReject` in `RMQSource` is called in case of already
processed (and checkpointed) but redelivered messages (e.g. after the job
failover)
## Verifying this change
This change added tests and can be verified as follows:
- `RMQSourceTest#testRedeliveredSessionIDsAck` which tests whether
redelivered messages are acknowledged properly
The change was also tested on a Flink 1.12 cluster on live data.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't
know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
