gaoyunhaii commented on a change in pull request #16184:
URL: https://github.com/apache/flink/pull/16184#discussion_r668415862
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -265,6 +265,14 @@ protected void declineCheckpoint(long checkpointId) {
@Override
public void run() {
+ if (operatorChain.isFinishedOnRestore()) {
Review comment:
I also think would be better to directly skipping the startup of source
thread. With this change the callback of `CompletionFuture` would be executed
in the main thread, but it should also be correct. I changed it to not start
the thread~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
