[
https://issues.apache.org/jira/browse/FLINK-23007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17379766#comment-17379766
]
Timo Walther commented on FLINK-23007:
--------------------------------------
[~TsReaper] the logs are currently full of errors like:
{code}
2021-07-12T20:44:24.0059271Z line 221:17 missing ';' at '('
2021-07-12T20:44:24.0063922Z line 221:59 mismatched input ',' expecting ')'
2021-07-12T20:44:24.0070238Z line 221:80 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0076791Z line 223:69 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0079044Z line 224:33 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0081798Z line 225:65 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0088060Z line 226:16 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0089917Z line 227:76 extraneous input ')' expecting ';'
2021-07-12T20:44:24.0792855Z line 385:17 missing ';' at '('
2021-07-12T20:44:24.0796518Z line 385:59 mismatched input ',' expecting ')'
2021-07-12T20:44:24.0800736Z line 385:80 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0805884Z line 387:69 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0808360Z line 388:33 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0810762Z line 389:65 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0817301Z line 390:15 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0818725Z line 391:75 extraneous input ')' expecting ';'
2021-07-12T20:44:24.1364946Z line 339:17 missing ';' at '('
2021-07-12T20:44:24.1366054Z line 339:59 mismatched input ',' expecting ')'
2021-07-12T20:44:24.1373495Z line 339:80 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1378822Z line 341:69 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1380984Z line 342:33 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1385438Z line 343:65 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1388520Z line 344:16 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1392687Z line 345:76 extraneous input ')' expecting ';'
2021-07-12T20:44:24.1633870Z line 221:17 missing ';' at '('
2021-07-12T20:44:24.1640923Z line 221:59 mismatched input ',' expecting ')'
2021-07-12T20:44:24.1647307Z line 221:80 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1654857Z line 223:69 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1659580Z line 224:33 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1664576Z line 225:65 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1669345Z line 226:16 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1672873Z line 227:75 extraneous input ')' expecting ';'
2021-07-12T20:44:24.1842542Z line 325:17 missing ';' at '('
2021-07-12T20:44:24.1846374Z line 325:59 mismatched input ',' expecting ')'
2021-07-12T20:44:24.1852461Z line 325:80 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1867352Z line 327:69 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1872101Z line 328:33 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1876855Z line 329:65 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1888644Z line 330:15 mismatched input ',' expecting ';'
2021-07-12T20:44:24.1892271Z line 331:75 extraneous input ')' expecting ';'
{code}
I guess this is related to the code splitter logic? Is this covered already in
one of the subtasks? Otherwise we should create a new subtask.
> Introduce java code splitter to split generated code
> ----------------------------------------------------
>
> Key: FLINK-23007
> URL: https://issues.apache.org/jira/browse/FLINK-23007
> Project: Flink
> Issue Type: New Feature
> Components: Table SQL / Runtime
> Reporter: Jingsong Lee
> Assignee: Caizhi Weng
> Priority: Major
> Fix For: 1.14.0
>
>
> Current lots of "code of method of class grows beyond 64k".
> We have fixed by:
> https://issues.apache.org/jira/browse/FLINK-15430
> https://issues.apache.org/jira/browse/FLINK-16589
> But this approach is not perfect. It has many corner cases.
>
> We can introduce a post java class splitter, based on antlr4, anaysis code
> and split method to multi-methods.
>
> We can add this splitter in CompileUtils, then, every compile class can be
> split.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
