dmvk commented on pull request #15501: URL: https://github.com/apache/flink/pull/15501#issuecomment-878951183
From a quick look I think `leaderElectionEventHandler.onLeaderInformationChange` may be constly under some conditions. In that case I'd rather propose changing `Watch watch(String name, WatchCallbackHandler<T> callbackHandler);` method signature, to something like `Watch watch(String name, WatchCallbackHandler<T> callbackHandler, ExecutorService callbackExecutor);`. That should allow us to be more flexible when it comes to blocking callbacks (it's also very similar to what can be found in java concurrent APIs). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
