Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2054#discussion_r65253162
--- Diff:
flink-streaming-connectors/flink-connector-rabbitmq/src/main/java/org/apache/flink/streaming/connectors/rabbitmq/RMQSink.java
---
@@ -35,24 +36,28 @@
private static final Logger LOG =
LoggerFactory.getLogger(RMQSink.class);
private String QUEUE_NAME;
- private String HOST_NAME;
+ private RMQConnectionConfig rmqConnectionConfig;
private transient ConnectionFactory factory;
private transient Connection connection;
private transient Channel channel;
private SerializationSchema<IN> schema;
- public RMQSink(String HOST_NAME, String QUEUE_NAME,
SerializationSchema<IN> schema) {
- this.HOST_NAME = HOST_NAME;
+ /**
+ * @param rmqConnectionConfig The RabbiMQ connection configuration
{@link RMQConnectionConfig}.
+ * @param QUEUE_NAME The queue to publish messages to.
+ * @param schema A {@link SerializationSchema} for turning the Java
objects received into bytes
+ */
+ public RMQSink(RMQConnectionConfig rmqConnectionConfig, String
QUEUE_NAME, SerializationSchema<IN> schema) {
--- End diff --
Same here with the QUEUE_NAME
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
