tsreaper opened a new pull request #16489:
URL: https://github.com/apache/flink/pull/16489
(When merging this PR, please keep the two commits separated.)
## What is the purpose of the change
Currently due to the logic of code splitter, logs are full of errors like
```
2021-07-12T20:44:24.0059271Z line 221:17 missing ';' at '('
2021-07-12T20:44:24.0063922Z line 221:59 mismatched input ',' expecting ')'
2021-07-12T20:44:24.0070238Z line 221:80 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0076791Z line 223:69 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0079044Z line 224:33 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0081798Z line 225:65 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0088060Z line 226:16 mismatched input ',' expecting ';'
2021-07-12T20:44:24.0089917Z line 227:76 extraneous input ')' expecting ';'
2021-07-12T20:44:24.0792855Z line 385:17 missing ';' at '('
```
This is because Java grammar files currently does not deal with constructor
calls like `this(a, b)` and `super(a, b)`. This PR fixes this issue along with
cleaning up other unnecessary output.
## Brief change log
- Add support for constructor call in `JavaParser`
- Clean up unnecessary output in tests due to code splitting and compiling
logic
## Verifying this change
This change added tests and can be verified by running the added tests.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicablle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
