Airblader commented on a change in pull request #16492: URL: https://github.com/apache/flink/pull/16492#discussion_r669410774
########## File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/TransformationsTest.java ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.planner.plan.nodes.exec; + +import org.apache.flink.api.connector.source.Boundedness; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.streaming.api.transformations.LegacySourceTransformation; +import org.apache.flink.streaming.api.transformations.WithBoundedness; +import org.apache.flink.table.api.DataTypes; +import org.apache.flink.table.api.Schema; +import org.apache.flink.table.api.Table; +import org.apache.flink.table.api.TableDescriptor; +import org.apache.flink.table.api.bridge.java.StreamTableEnvironment; +import org.apache.flink.table.planner.utils.JavaStreamTableTestUtil; +import org.apache.flink.table.planner.utils.TableTestBase; + +import org.junit.Test; + +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; + +/** + * Various tests to check {@link Transformation}s that have been generated from {@link ExecNode}s. + */ +public class TransformationsTest extends TableTestBase { + + @Test + public void testLegacyBatchSource() { + final JavaStreamTableTestUtil util = javaStreamTestUtil(); + final StreamTableEnvironment env = util.tableEnv(); + + final Table table = + env.from( + TableDescriptor.forConnector("values") + .option("bounded", "true") + .schema(dummySchema()) + .build()); + + final LegacySourceTransformation<?> sourceTransform = + toLegacySourceTransformation(env, table); + + assertBoundedness(Boundedness.BOUNDED, sourceTransform); + } + + @Test + public void testLegacyStreamSource() { + final JavaStreamTableTestUtil util = javaStreamTestUtil(); + final StreamTableEnvironment env = util.tableEnv(); + + final Table table = + env.from( + TableDescriptor.forConnector("values") + .option("bounded", "false") + .schema(dummySchema()) + .build()); + + final LegacySourceTransformation<?> sourceTransform = + toLegacySourceTransformation(env, table); + + assertBoundedness(Boundedness.CONTINUOUS_UNBOUNDED, sourceTransform); + } + + // -------------------------------------------------------------------------------------------- + // Helper methods + // -------------------------------------------------------------------------------------------- + + private static LegacySourceTransformation<?> toLegacySourceTransformation( + StreamTableEnvironment env, Table table) { + final Transformation<?> transform = env.toChangelogStream(table).getTransformation(); + assertTrue(transform.getInputs().size() > 0); Review comment: `assertFalse(transform.getInputs().isEmpty())`? ########## File path: flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecTableSourceScan.java ########## @@ -107,6 +117,38 @@ public DynamicTableSourceSpec getTableSourceSpec() { } } + /** + * Adopted from {@link StreamExecutionEnvironment#addSource(SourceFunction, String, + * TypeInformation)} but with custom {@link Boundedness}. + */ + protected Transformation<RowData> createSourceFunctionTransformation( + StreamExecutionEnvironment env, + SourceFunction<RowData> function, + boolean isBounded, + String operatorName, + TypeInformation<RowData> outputTypeInfo) { + + env.clean(function); + + final int parallelism; + if (function instanceof ParallelSourceFunction) { + parallelism = env.getParallelism(); + } else { + parallelism = 1; + } + + final Boundedness boundedness; + if (isBounded) { Review comment: nit: a ternary would seem appropriate to me here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
