twalthr commented on a change in pull request #16396:
URL: https://github.com/apache/flink/pull/16396#discussion_r669586256



##########
File path: 
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/RexNodeExtractor.scala
##########
@@ -532,7 +531,14 @@ class RexNodeToExpressionConverter(
     Try(functionCatalog.lookupFunction(identifier)) match {
       case Success(f: java.util.Optional[FunctionLookup.Result]) =>
         if (f.isPresent) {
-          Some(new CallExpression(f.get().getFunctionDefinition, operands, 
outputType))
+          val identifier = f.get.getFunctionDefinition match {

Review comment:
       we could simplify this logic if FLINK-23384 would be fixed, I will add a 
comment above those lines




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to