tillrohrmann commented on a change in pull request #16357:
URL: https://github.com/apache/flink/pull/16357#discussion_r670571886
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatMonitorImpl.java
##########
@@ -70,6 +81,11 @@
"The heartbeat timeout interval has to be larger than 0.");
this.heartbeatTimeoutIntervalMs = heartbeatTimeoutIntervalMs;
+ Preconditions.checkArgument(
+ failedRpcRequestsUntilUnreachable > 0 ||
failedRpcRequestsUntilUnreachable == -1,
+ "The number of failed heartbeat RPC requests has to be larger
than 0 or -1 (deactivated).");
Review comment:
I think this makes sense, yes. I'll add it there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
