[ 
https://issues.apache.org/jira/browse/FLINK-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310383#comment-15310383
 ] 

ASF GitHub Bot commented on FLINK-3908:
---------------------------------------

Github user zentol commented on the pull request:

    https://github.com/apache/flink/pull/2007
  
    i believe what Stephan meant was the following:
    * keep the abstract parseField method in FieldParser
    * add a new method to FieldParser called resetErrorStateAndParse, which 
calls resetParserState and parseField
    
    This would require reverting all changes you made to specific parsers (like 
LongValueParser), and modifiying each call to parseField from outside the 
parser, like the GenericCsvInputFormat.


> FieldParsers error state is not reset correctly to NONE
> -------------------------------------------------------
>
>                 Key: FLINK-3908
>                 URL: https://issues.apache.org/jira/browse/FLINK-3908
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.2
>            Reporter: Flavio Pompermaier
>            Assignee: Flavio Pompermaier
>              Labels: parser
>
> If during the parse of a csv there's a parse error (for example when in a 
> integer column there are non-int values) the errorState is not reset 
> correctly in the next parseField call. A simple fix would be to add as a 
> first statement of the {{parseField()}} function a call to 
> {{setErrorState(ParseErrorState.NONE)}} but it is something that should be 
> handled better (by default) for every subclass of {{FieldParser<T>}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to