zhuzhurk commented on a change in pull request #16498:
URL: https://github.com/apache/flink/pull/16498#discussion_r671089379
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/BlobServerOptions.java
##########
@@ -118,4 +118,10 @@
key("blob.client.connect.timeout")
.defaultValue(0)
.withDescription("The connection timeout in milliseconds
for the blob client.");
+
+ /** The maximum size limit of blob cache on TaskExecutor. */
+ public static final ConfigOption<Long> BLOB_CACHE_SIZE_LIMIT =
+ key("blob.cache.size.limit")
+ .defaultValue(1_024 * 1_024 * 1_024 * 10L)
+ .withDescription("The maximum size limit of blob cache for
each TaskExecutor.");
Review comment:
the description needs clearly state how it affects permanent blob and
transient blob size.
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/BlobServerOptions.java
##########
@@ -118,4 +118,10 @@
key("blob.client.connect.timeout")
.defaultValue(0)
.withDescription("The connection timeout in milliseconds
for the blob client.");
+
+ /** The maximum size limit of blob cache on TaskExecutor. */
+ public static final ConfigOption<Long> BLOB_CACHE_SIZE_LIMIT =
+ key("blob.cache.size.limit")
+ .defaultValue(1_024 * 1_024 * 1_024 * 10L)
+ .withDescription("The maximum size limit of blob cache for
each TaskExecutor.");
Review comment:
the description needs to clearly state how it affects permanent blob and
transient blob size limit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
