NicoK edited a comment on pull request #16352:
URL: https://github.com/apache/flink/pull/16352#issuecomment-881735379


   Sorry @paul8263 for letting you wait. I think, the code looks good in 
general also with respect to improving how the different states are shown, 
solving FLINK-22527 and FLINK-23101 along the way (and thus making #16419 
obsolete).
   Before we can merge, can you two things?
   
   1. Rebase onto latest `master` - that should help solving the other test 
failures in the CI build (I'm expecting any but `RestAPIStabilityTest` to be 
unrelated, but want to be sure)
   2. `RestAPIStabilityTest.testDispatcherRestAPIStability` is still failing, 
please run the following two commands and commit the diff (I'm afraid, there 
were a few typos in @zentol's commands above)
       ```
       mvn package -Dgenerate-rest-docs -pl flink-docs -am -nsu -DskipTests
       mvn verify -Dtest=RestAPIStabilityTest -Dgenerate-rest-snapshot -pl 
flink-runtime-web
       ```
     It fails for me but generates the needed changes (and if you run again 
without `-Dgenerate-rest-snapshot` it succeeds.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to