godfreyhe opened a new pull request #16539:
URL: https://github.com/apache/flink/pull/16539


   
   ## What is the purpose of the change
   
   *Fix the inconsistent type in IncrementalAggregateRule when the query has 
one distinct agg function and count star agg function. See the JIRA description 
for more detail about the exception.*
   
   
   ## Brief change log
   
     - *Fix the wrong the logic in IncrementalAggregateRule*
     - *Add indexOfCountStar to tell the global agg where is the existing count 
start*
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - *Extended IncrementalAggregateTest to verify the plan*
     -  *Extended SplitAggregateITCase to verify the execution result*
     -  *Extended IncrementalAggregateJsonPlanTest to verify the json ser 
result*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't 
know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ **not documented**)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to