curcur commented on a change in pull request #16531:
URL: https://github.com/apache/flink/pull/16531#discussion_r673712463
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/Environment.java
##########
@@ -232,4 +234,20 @@ void acknowledgeCheckpoint(
IndexedInputGate[] getAllInputGates();
TaskEventDispatcher getTaskEventDispatcher();
+
+ //
--------------------------------------------------------------------------------------------
+ // Fields set in the StreamTask to provide access to mailbox and other
runtime resources
+ //
--------------------------------------------------------------------------------------------
+
+ default void setMainMailboxExecutor(MailboxExecutor mainMailboxExecutor) {}
+
+ default MailboxExecutor getMainMailboxExecutor() {
Review comment:
In MockEnvironment, both mailboxExecutor and asycnThreadPool are
initialized, and I marked the parameter of `set method` as not nullable. So a
`get method` won't return a null;
I will add the check in `RuntimeEnvironment Getter`
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/execution/Environment.java
##########
@@ -232,4 +234,20 @@ void acknowledgeCheckpoint(
IndexedInputGate[] getAllInputGates();
TaskEventDispatcher getTaskEventDispatcher();
+
+ //
--------------------------------------------------------------------------------------------
+ // Fields set in the StreamTask to provide access to mailbox and other
runtime resources
+ //
--------------------------------------------------------------------------------------------
+
+ default void setMainMailboxExecutor(MailboxExecutor mainMailboxExecutor) {}
+
+ default MailboxExecutor getMainMailboxExecutor() {
Review comment:
I do not like Optional, I will add a check in `get`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
