hhkkxxx133 commented on a change in pull request #16513:
URL: https://github.com/apache/flink/pull/16513#discussion_r674120565
##########
File path:
flink-formats/flink-avro-glue-schema-registry/src/main/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryOutputStreamSerializer.java
##########
@@ -72,17 +72,17 @@ public void registerSchemaAndSerializeStream(Schema schema,
OutputStream out, by
glueSchemaRegistrySerializationFacade.encode(
transportName,
new
com.amazonaws.services.schemaregistry.common.Schema(
- schema.toString(), "Avro", getSchemaName()),
+ schema.toString(), "AVRO", getSchemaName()),
Review comment:
Yess I can change to use constant.
##########
File path:
flink-formats/flink-avro-glue-schema-registry/src/test/java/org/apache/flink/formats/avro/glue/schema/registry/GlueSchemaRegistryInputStreamDeserializerTest.java
##########
@@ -205,12 +209,13 @@ public void
testGetSchemaAndDeserializedStream_withWrongSchema_throwsException()
MutableByteArrayInputStream mutableByteArrayInputStream = new
MutableByteArrayInputStream();
glueSchema =
new com.amazonaws.services.schemaregistry.common.Schema(
- schemaDefinition, "Avro", testTopic);
- mockDeserializer =
- new MockAWSDeserializer(
- new byte[0], glueSchema,
AWSSchemaRegistryConstants.COMPRESSION.NONE);
+ schemaDefinition, "AVRO", testTopic);
Review comment:
Will change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
