tillrohrmann commented on a change in pull request #16543:
URL: https://github.com/apache/flink/pull/16543#discussion_r674903752



##########
File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/minicluster/MiniClusterITCase.java
##########
@@ -159,6 +160,8 @@ private void 
setupAndRunHandleJobsWhenNotEnoughSlots(ScheduleMode scheduleMode)
     private void runHandleJobsWhenNotEnoughSlots(final JobGraph jobGraph) 
throws Exception {
         final Configuration configuration = getDefaultConfiguration();
         configuration.setLong(JobManagerOptions.SLOT_REQUEST_TIMEOUT, 100L);
+        configuration.setLong(
+                ResourceManagerOptions.STANDALONE_CLUSTER_STARTUP_PERIOD_TIME, 
10000L);

Review comment:
       The test tests that batch slot requests are timed out on the `JobMaster` 
side via the slot request timeout. Since they are batch slot requests and there 
is at least on slot that can fulfill all slot requests, they won't be failed on 
the `ResourceManager` side. This, however, only works if the `TaskExecutor` 
registers within the `STANDALONE_CLUSTER_STARTUP_PERIOD_TIME` because otherwise 
there is no slot on the RM registered that can fulfill the slot requests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to