zentol commented on a change in pull request #16578:
URL: https://github.com/apache/flink/pull/16578#discussion_r675335486
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/ExecutionConfigOptions.java
##########
@@ -336,15 +337,20 @@
+ "\"SortMergeJoin\", \"HashAgg\",
\"SortAgg\".\n"
+ "By default no operator is disabled.");
+ @Deprecated
@Documentation.TableOption(execMode = Documentation.ExecMode.BATCH)
public static final ConfigOption<String> TABLE_EXEC_SHUFFLE_MODE =
key("table.exec.shuffle-mode")
.stringType()
- .defaultValue("ALL_EDGES_BLOCKING")
+ .noDefaultValue()
.withDescription(
Description.builder()
.text("Sets exec shuffle mode.")
.linebreak()
+ .text(
+ "This option is deprecated. Use
the core option '%s' instead.",
Review comment:
Deprecated options are excluded from the documentation, so no one's
gonna read this? (maybe put it in the javadocs instead)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
