zentol commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r675357493
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -258,7 +258,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
+ <version>4.5.13</version>
Review comment:
Why is this entry still there? Was there a problem after removing it?
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -234,17 +232,6 @@ under the License.
<version>${aws.sdkv2.version}</version>
</dependency>
- <dependency>
- <groupId>org.apache.httpcomponents</groupId>
- <artifactId>httpclient</artifactId>
Review comment:
These should actually stay. This ensures that if a _user_ bundles this
this connector in the jar they still get this version of the dependency. In
that scenario what we define in the dependency management is completely ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
