Thesharing commented on a change in pull request #16314:
URL: https://github.com/apache/flink/pull/16314#discussion_r676063843
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/TaskDeploymentDescriptorFactory.java
##########
@@ -123,42 +134,48 @@ public TaskDeploymentDescriptor
createDeploymentDescriptor(
resultId,
partitionType,
queueToRequest,
-
getConsumedPartitionShuffleDescriptors(partitions)));
+ getConsumedPartitionShuffleDescriptors(
+ consumedIntermediateResult,
consumedPartitionGroup)));
}
return inputGates;
}
- private ShuffleDescriptor[] getConsumedPartitionShuffleDescriptors(
- List<IntermediateResultPartition> partitions) {
+ private SerializedValue<ShuffleDescriptor[]>
getConsumedPartitionShuffleDescriptors(
+ IntermediateResult intermediateResult, ConsumedPartitionGroup
consumedPartitionGroup)
+ throws IOException {
+ SerializedValue<ShuffleDescriptor[]> serializedShuffleDescriptors =
+
intermediateResult.getCachedShuffleDescriptors(consumedPartitionGroup);
+ if (serializedShuffleDescriptors == null) {
+ serializedShuffleDescriptors =
+
computeConsumedPartitionShuffleDescriptors(consumedPartitionGroup);
+ intermediateResult.cacheShuffleDescriptors(
+ consumedPartitionGroup, serializedShuffleDescriptors);
+ }
+ return serializedShuffleDescriptors;
+ }
- ShuffleDescriptor[] shuffleDescriptors = new
ShuffleDescriptor[partitions.size()];
+ private SerializedValue<ShuffleDescriptor[]>
computeConsumedPartitionShuffleDescriptors(
+ ConsumedPartitionGroup consumedPartitionGroup) throws IOException {
+
+ ShuffleDescriptor[] shuffleDescriptors =
+ new ShuffleDescriptor[consumedPartitionGroup.size()];
// Each edge is connected to a different result partition
- for (int i = 0; i < partitions.size(); i++) {
- shuffleDescriptors[i] =
+ int i = 0;
+ for (IntermediateResultPartitionID partitionId :
consumedPartitionGroup) {
+ shuffleDescriptors[i++] =
getConsumedPartitionShuffleDescriptor(
Review comment:
Documents added.
##########
File path:
flink-core/src/main/java/org/apache/flink/util/CompressedSerializedValue.java
##########
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License
+ */
+
+package org.apache.flink.util;
+
+import java.io.IOException;
+
+/** An extension of {@link SerializedValue} that compresses the value after
the serialization. */
+public class CompressedSerializedValue<T> extends SerializedValue<T> {
+
+ private static final long serialVersionUID = -4358765382738374654L;
+
+ private CompressedSerializedValue(byte[] serializedData) {
Review comment:
`CompressedSerializedValue#frombytes` has been moved to the second pull
request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
