pnowojski commented on a change in pull request #16589:
URL: https://github.com/apache/flink/pull/16589#discussion_r676435145
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceOperatorStreamTask.java
##########
@@ -122,6 +117,9 @@ protected void finishTask() throws Exception {
public Future<Boolean> triggerCheckpointAsync(
CheckpointMetaData checkpointMetaData, CheckpointOptions
checkpointOptions) {
if (!isExternallyInducedSource) {
+ if (checkpointOptions.getCheckpointType().shouldDrain()) {
+ mainMailboxExecutor.execute(this::endData, "Drain pipeline on
stop-with-savepoint");
+ }
Review comment:
We need a test case what should happen if `stop-with-savepoint --drain`
fails - job should failover, because we have already emitted
`MAX_WATERMARK`/`endInput`
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/sort/CollectionDataInput.java
##########
@@ -46,6 +47,10 @@
@Override
public DataInputStatus emitNext(DataOutput<E> output) throws Exception {
+ if (endOfInput) {
+ return DataInputStatus.END_OF_INPUT;
+ }
Review comment:
move to the bottom?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
