zhuzhurk commented on a change in pull request #16314: URL: https://github.com/apache/flink/pull/16314#discussion_r676510233
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/IntermediateResultTest.java ########## @@ -0,0 +1,259 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License + */ + +package org.apache.flink.runtime.executiongraph; + +import org.apache.flink.runtime.JobException; +import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutor; +import org.apache.flink.runtime.concurrent.ComponentMainThreadExecutorServiceAdapter; +import org.apache.flink.runtime.execution.ExecutionState; +import org.apache.flink.runtime.executiongraph.failover.flip1.TestRestartBackoffTimeStrategy; +import org.apache.flink.runtime.io.network.partition.ResultPartitionType; +import org.apache.flink.runtime.jobgraph.DistributionPattern; +import org.apache.flink.runtime.jobgraph.JobGraph; +import org.apache.flink.runtime.jobgraph.JobGraphBuilder; +import org.apache.flink.runtime.jobgraph.JobVertex; +import org.apache.flink.runtime.jobgraph.JobVertexID; +import org.apache.flink.runtime.jobgraph.tasks.AbstractInvokable; +import org.apache.flink.runtime.jobmaster.LogicalSlot; +import org.apache.flink.runtime.jobmaster.TestingLogicalSlotBuilder; +import org.apache.flink.runtime.scheduler.DefaultScheduler; +import org.apache.flink.runtime.scheduler.SchedulerTestingUtils; +import org.apache.flink.runtime.shuffle.ShuffleDescriptor; +import org.apache.flink.runtime.taskmanager.TaskExecutionState; +import org.apache.flink.util.SerializedValue; +import org.apache.flink.util.TestLogger; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.List; +import java.util.Objects; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.Executors; +import java.util.concurrent.ScheduledExecutorService; +import java.util.concurrent.TimeoutException; + +import static org.apache.flink.runtime.deployment.TaskDeploymentDescriptorFactoryTest.deserializeShuffleDescriptors; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNull; + +/** Tests for {@link IntermediateResult}. */ +public class IntermediateResultTest extends TestLogger { + + private static final int PARALLELISM = 4; + + private ScheduledExecutorService scheduledExecutorService; + private ComponentMainThreadExecutor mainThreadExecutor; + + @Before + public void setup() { + scheduledExecutorService = Executors.newSingleThreadScheduledExecutor(); + mainThreadExecutor = + ComponentMainThreadExecutorServiceAdapter.forSingleThreadExecutor( + scheduledExecutorService); + } + + @After + public void teardown() { + if (scheduledExecutorService != null) { + scheduledExecutorService.shutdownNow(); + } + } + + @Test + public void testRemoveShuffleDescriptorCacheAfterFinished() throws Exception { + + final JobVertex v1 = createJobVertex("v1", PARALLELISM); + final JobVertex v2 = createJobVertex("v2", PARALLELISM); + + final ExecutionGraph executionGraph = + createExecutionGraphAndDeploy(v1, v2, mainThreadExecutor); + + // ShuffleDescriptors should be cached during the deployment + final ShuffleDescriptor[] shuffleDescriptors = + deserializeShuffleDescriptors(getCachedShuffleDescriptor(executionGraph, v2)); + assertEquals(PARALLELISM, shuffleDescriptors.length); + + CompletableFuture.runAsync( + () -> transitionTasksToFinished(executionGraph, v2.getID()), + mainThreadExecutor) + .join(); + + // Cache should be removed when partitions are released + assertNull(getCachedShuffleDescriptor(executionGraph, v2)); + } + + @Test + public void testCacheRemovedCorrectlyAfterFailover() throws Exception { + + final JobVertex v1 = createJobVertex("v1", PARALLELISM); + final JobVertex v2 = createJobVertex("v2", PARALLELISM); + + final ExecutionGraph executionGraph = + createExecutionGraphAndDeploy(v1, v2, mainThreadExecutor); + + // ShuffleDescriptors should be cached during the deployment + final ShuffleDescriptor[] shuffleDescriptors = + deserializeShuffleDescriptors(getCachedShuffleDescriptor(executionGraph, v2)); + assertEquals(PARALLELISM, shuffleDescriptors.length); + + triggerExceptionAndComplete(executionGraph, v1, v2); + + // Cache should be removed during ExecutionVertex#resetForNewExecution + assertNull(getCachedShuffleDescriptor(executionGraph, v2)); + } + + private static ExecutionGraph createExecutionGraphAndDeploy( + JobVertex v1, JobVertex v2, ComponentMainThreadExecutor mainThreadExecutor) + throws Exception { + + v2.connectNewDataSetAsInput( + v1, DistributionPattern.ALL_TO_ALL, ResultPartitionType.BLOCKING); + + final List<JobVertex> ordered = new ArrayList<>(Arrays.asList(v1, v2)); + final DefaultScheduler scheduler = createScheduler(ordered, mainThreadExecutor); + final ExecutionGraph executionGraph = scheduler.getExecutionGraph(); + final TestingLogicalSlotBuilder slotBuilder = new TestingLogicalSlotBuilder(); + + CompletableFuture.runAsync( + () -> { + try { + // Deploy upstream source vertices + deployTasks(executionGraph, v1.getID(), slotBuilder); + // Transition upstream vertices into FINISHED + transitionTasksToFinished(executionGraph, v1.getID()); + // Deploy downstream sink vertices + deployTasks(executionGraph, v2.getID(), slotBuilder); + } catch (Exception e) { + e.printStackTrace(); Review comment: We should fail the test here because exception is not expected to happen. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
