beyond1920 commented on a change in pull request #16521: URL: https://github.com/apache/flink/pull/16521#discussion_r676535856
########## File path: flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/window/WindowTableFunctionOperator.java ########## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.window; + +import org.apache.flink.streaming.api.operators.ChainingStrategy; +import org.apache.flink.streaming.api.operators.OneInputStreamOperator; +import org.apache.flink.streaming.api.operators.TimestampedCollector; +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord; +import org.apache.flink.table.data.GenericRowData; +import org.apache.flink.table.data.RowData; +import org.apache.flink.table.data.TimestampData; +import org.apache.flink.table.data.utils.JoinedRowData; +import org.apache.flink.table.runtime.operators.TableStreamOperator; +import org.apache.flink.table.runtime.operators.window.assigners.WindowAssigner; +import org.apache.flink.table.runtime.util.TimeWindowUtil; + +import java.time.ZoneId; +import java.util.Collection; +import java.util.function.LongUnaryOperator; + +import static org.apache.flink.util.Preconditions.checkArgument; + +/** + * The WindowTableFunctionOperator acts as a table-valued function to assign windows for input row. + * Output row includes the original columns as well additional 3 columns named {@code window_start}, + * {@code window_end}, {@code window_time} to indicate the assigned window. + * + * <p>Note: The operator only works for row-time. + * + * <p>Note: The operator emits per record instead of at the end of window. + */ +public class WindowTableFunctionOperator extends TableStreamOperator<RowData> + implements OneInputStreamOperator<RowData, RowData> { + + private static final long serialVersionUID = 1L; + + private final WindowAssigner<TimeWindow> windowAssigner; + private final int rowtimeIndex; + + /** + * The shift timezone of the window, if the proctime or rowtime type is TIMESTAMP_LTZ, the shift + * timezone is the timezone user configured in TableConfig, other cases the timezone is UTC + * which means never shift when assigning windows. + */ + private final ZoneId shiftTimeZone; + + /** This is used for emitting elements with a given timestamp. */ + private transient TimestampedCollector<RowData> collector; + + private transient JoinedRowData outRow; + private transient GenericRowData windowProperties; + private transient LongUnaryOperator getShiftEpochMillsFunc; + + public WindowTableFunctionOperator( + WindowAssigner<TimeWindow> windowAssigner, int rowtimeIndex, ZoneId shiftTimeZone) { + checkArgument(windowAssigner.isEventTime() && rowtimeIndex >= 0); + this.windowAssigner = windowAssigner; + this.rowtimeIndex = rowtimeIndex; + this.shiftTimeZone = shiftTimeZone; + + setChainingStrategy(ChainingStrategy.ALWAYS); + } + + @Override + public void open() throws Exception { + super.open(); + this.collector = new TimestampedCollector<>(output); + collector.eraseTimestamp(); + + if (shiftTimeZone.getId().equals("UTC")) { + getShiftEpochMillsFunc = LongUnaryOperator.identity(); + } else { + getShiftEpochMillsFunc = time -> TimeWindowUtil.toEpochMills(time, shiftTimeZone); + } + + outRow = new JoinedRowData(); + windowProperties = new GenericRowData(3); + } + + @Override + public void processElement(StreamRecord<RowData> element) throws Exception { + RowData inputRow = element.getValue(); + long timestamp = inputRow.getTimestamp(rowtimeIndex, 3).getMillisecond(); + timestamp = TimeWindowUtil.toUtcTimestampMills(timestamp, shiftTimeZone); + Collection<TimeWindow> elementWindows = windowAssigner.assignWindows(inputRow, timestamp); + for (TimeWindow window : elementWindows) { + windowProperties.setField(0, TimestampData.fromEpochMillis(window.getStart())); + windowProperties.setField(1, TimestampData.fromEpochMillis(window.getEnd())); + windowProperties.setField( + 2, + TimestampData.fromEpochMillis( + getShiftEpochMillsFunc.applyAsLong(window.getEnd() - 1))); Review comment: @JingsongLi I removed `LongUnaryOperator` because branch predication in JAVA may cover the optimization. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
