nicoweidner commented on a change in pull request #16597: URL: https://github.com/apache/flink/pull/16597#discussion_r676741678
########## File path: flink-rpc/flink-rpc-akka-loader/src/test/java/org/apache/flink/runtime/rpc/akka/AkkaRpcSystemLoaderTest.java ########## @@ -0,0 +1,57 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.rpc.akka; + +import org.apache.flink.configuration.Configuration; +import org.apache.flink.configuration.CoreOptions; +import org.apache.flink.runtime.rpc.RpcSystem; +import org.apache.flink.util.TestLogger; + +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import java.nio.file.Paths; + +import static org.hamcrest.CoreMatchers.not; +import static org.hamcrest.CoreMatchers.nullValue; +import static org.hamcrest.MatcherAssert.assertThat; + +/** Tests for the {@link AkkaRpcSystemLoader}. */ +public class AkkaRpcSystemLoaderTest extends TestLogger { + + private static final AkkaRpcSystemLoader LOADER = new AkkaRpcSystemLoader(); + + @ClassRule public static final TemporaryFolder TMP_DIR = new TemporaryFolder(); + + @Test + public void testServiceLoadingWithDefaultConfig() { + assertThat(LOADER.loadRpcSystem(new Configuration()), not(nullValue())); Review comment: Shouldn't this test wrap `loadRpcSystem` in a try with resources as well? I assume the reason is to make sure to cleanup the temp file, which is created in this test as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
