nicoweidner commented on a change in pull request #16595:
URL: https://github.com/apache/flink/pull/16595#discussion_r676763465
##########
File path: tools/azure-pipelines/build-nightly-dist.yml
##########
@@ -109,7 +109,7 @@ jobs:
</settings>
EOF
- export CUSTOM_OPTIONS="-Dgpg.skip -Drat.skip -Dcheckstyle.skip
-Dmaven.wagon.http.pool=false --settings $(pwd)/deploy-settings.xml"
+ export CUSTOM_OPTIONS="${MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR}
-Dgpg.skip -Drat.skip -Dcheckstyle.skip --settings $(pwd)/deploy-settings.xml"
Review comment:
Is it intended that we propagate some options that were not there
before? Logging was mentioned in the description, but `--no-snapshot updates -B
$PROFILE` is now also applied in
https://github.com/apache/flink/blob/master/tools/releasing/deploy_staging_jars.sh#L46-L50
##########
File path: tools/ci/maven-utils.sh
##########
@@ -107,3 +105,6 @@ MVN_GLOBAL_OPTIONS+="--no-snapshot-updates "
MVN_GLOBAL_OPTIONS+="-B "
# globally control the build profile details
MVN_GLOBAL_OPTIONS+="$PROFILE "
Review comment:
all the options except the `--settings` one should be added to
`MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR`, shouldn't they?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
