zentol commented on a change in pull request #16601:
URL: https://github.com/apache/flink/pull/16601#discussion_r677184362
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/rpc/TestingRpcService.java
##########
@@ -51,7 +52,11 @@
* verify(testGateway, timeout(1000)).theTestMethod(any(UUID.class),
anyString());
* }</pre>
*/
-public class TestingRpcService extends AkkaRpcService {
+public class TestingRpcService implements RpcService {
+
+ // load RpcSystem only once to save initialization costs
+ // this is safe because it is state-less
+ private static final RpcSystem RPC_SYSTEM_SINGLETON = RpcSystem.load();
Review comment:
we could think about adding a JVM shutdown hook because this does leak a
50mb temp file, but it's a temp file so ... 🤷
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
