pnowojski commented on a change in pull request #16582:
URL: https://github.com/apache/flink/pull/16582#discussion_r677345113



##########
File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamOperator.java
##########
@@ -43,7 +43,7 @@
  * @param <OUT> The output type of the operator
  */
 @PublicEvolving
-public interface StreamOperator<OUT> extends CheckpointListener, KeyContext, 
Serializable {
+public interface StreamOperator<OUT> extends InternalCheckpointListener, 
KeyContext, Serializable {

Review comment:
       I'm also not sure if it makes sense to expose 
`notifyCheckpointSubsumed()` to the users. And if we don't have a good 
motivating example, I would prefer to not expose it. Why clog the public API at 
best? And at worst this could cause us problems down the road for providing 
backward compatibility/refactoring. If needed, we can always add this 
notification later. Removing and maintaining things is harder.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to