zhuzhurk commented on a change in pull request #16498:
URL: https://github.com/apache/flink/pull/16498#discussion_r677165668
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/blob/PermanentBlobService.java
##########
@@ -45,4 +46,21 @@
* @throws IOException if any other error occurs when retrieving the file
*/
File getFile(JobID jobId, PermanentBlobKey key) throws IOException;
+
+ /**
+ * Directly read the file associated with the provided job ID and blob key.
+ *
+ * <p>Compared to {@code getFile}, {@code readFile} makes sure that the
file is fully read when
Review comment:
>>> {@code readFile} makes sure that ..
I think it's not very accurate because `readFile` does not guarantee that.
However, it provides the possibility to achieve that, if the file reading and
file retrieving happens in the same write lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
