gaoyunhaii commented on a change in pull request #16557:
URL: https://github.com/apache/flink/pull/16557#discussion_r677635926
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SubtaskCheckpointCoordinatorImpl.java
##########
@@ -76,10 +76,6 @@
private static final int CHECKPOINT_EXECUTION_DELAY_LOG_THRESHOLD_MS =
30_000;
- /**
- * TODO Whether enables checkpoints after tasks finished. This is a
temporary flag and will be
- * removed in the last PR.
- */
private boolean enableCheckpointAfterTasksFinished;
Review comment:
Might also be `final` ?
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -712,7 +718,10 @@ protected void afterInvoke() throws Exception {
// tasks. During this process, this task could coordinate with its
downstream tasks to
// continue perform checkpoints.
CompletableFuture<Void> allRecordsProcessedFuture;
- if (configuration.isCheckpointingEnabled()) {
+ if (configuration
Review comment:
Below there is also a part that
```java
// No new checkpoints could be triggered since mailbox has been drained.
subtaskCheckpointCoordinator.waitForPendingCheckpoints();
LOG.debug("All pending checkpoints are finished");
```
should also be enabled only when the flag is true and checkpoint is enabled.
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/CheckpointBarrierHandler.java
##########
@@ -76,15 +76,19 @@
* TODO Whether enables checkpoints after tasks finished. This is a
temporary flag and will be
Review comment:
Might also remove this comment for consistency with other modification~?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
