Piotr Nowojski created FLINK-23527:
--------------------------------------

             Summary: Clarify `SourceFunction#cancel()` contract about 
interrupting
                 Key: FLINK-23527
                 URL: https://issues.apache.org/jira/browse/FLINK-23527
             Project: Flink
          Issue Type: Bug
          Components: API / DataStream
    Affects Versions: 1.13.1
            Reporter: Piotr Nowojski
             Fix For: 1.14.0


We should clarify the contract of {{SourceFunction#cancel()}}

# source itself shouldn’t be interrupting the source thread
# interrupt shouldn’t be expected in the clean cancellation case

Interrupting the code on the clean shutdown path can cause failures when doing 
`stop-with-savepoint`. If source thread is interrupted during backpressure, 
this leaves network stack in invalid state, making it impossible to send 
{{EndOfPartitionEvent}} to complete the shutdown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to