zhuzhurk commented on a change in pull request #16498: URL: https://github.com/apache/flink/pull/16498#discussion_r678201387
########## File path: flink-runtime/src/test/java/org/apache/flink/runtime/blob/PermanentBlobCacheSizeLimitTest.java ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License + */ + +package org.apache.flink.runtime.blob; + +import org.apache.flink.api.common.JobID; +import org.apache.flink.configuration.BlobServerOptions; +import org.apache.flink.configuration.Configuration; +import org.apache.flink.util.concurrent.FutureUtils; + +import org.junit.Rule; +import org.junit.Test; +import org.junit.rules.TemporaryFolder; + +import javax.annotation.Nullable; + +import java.io.File; +import java.io.IOException; +import java.net.InetSocketAddress; +import java.util.ArrayList; +import java.util.List; +import java.util.Random; +import java.util.concurrent.CompletableFuture; +import java.util.concurrent.CompletionException; +import java.util.concurrent.ExecutorService; +import java.util.concurrent.Executors; + +import static org.apache.flink.runtime.blob.BlobServerPutTest.put; +import static org.junit.Assert.assertArrayEquals; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertTrue; + +/** + * Test for using {@link BlobCacheSizeTracker} to track the size of BLOBs in {@link + * PermanentBlobCache}. When new BLOBs are intended to be stored and the size limit exceeds, {@link + * BlobCacheSizeTracker} will provide excess BLOBs for {@link PermanentBlobCache} to delete. + */ +public class PermanentBlobCacheSizeLimitTest { + + private static final Random RANDOM = new Random(); + + private static final BlobKey.BlobType BLOB_TYPE = BlobKey.BlobType.PERMANENT_BLOB; + private static final int BLOB_SIZE = 10_000; + // The size limit is the size of 2 blobs + private static final int MAX_NUM_OF_ACCEPTED_BLOBS = 2; + private static final int TOTAL_NUM_OF_BLOBS = 3; + + @Rule public final TemporaryFolder temporaryFolder = new TemporaryFolder(); + + @Test + public void testTrackSizeLimitAndDeleteExcessSequentially() throws Exception { + + final Configuration config = new Configuration(); + config.setString( + BlobServerOptions.STORAGE_DIRECTORY, temporaryFolder.newFolder().getAbsolutePath()); + + try (BlobServer server = new BlobServer(config, new VoidBlobStore()); + BlobCacheService cache = Review comment: Looks to me the `config` can be a class wide field. And seems `initBlobCacheServiceWithSizeLimit()` can be param-less. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
