GitHub user tzulitai opened a pull request:

    https://github.com/apache/flink/pull/2081

    [FLINK-4020][streaming-connectors] Move shard list querying to open() for 
Kinesis consumer

    Remove shard list querying from the constructor, and let all subtasks 
independently discover which shards it should consume from in open(). This 
change is a prerequisite for 
[FLINK-3231](https://issues.apache.org/jira/browse/FLINK-3231).
    
    Explanation for some changes that might seem irrelevant:
    1. Changed naming of some variables / methods: Since the behaviour of shard 
assignment to subtasks is now (and will continue to be in the future after 
FLINK-3231) more like "discovering shards for consuming" instead of "being 
assigned shards", I've changed the "assignedShards" related namings to 
"discoveredShards".
    2. I've removed some tests, due to the fact that the corresponding parts of 
the code will be subject to quite a bit of change with the upcoming changes of 
[FLINK-3231](https://issues.apache.org/jira/browse/FLINK-3231). Tests will be 
added back with FLINK-3231.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tzulitai/flink FLINK-4020

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2081.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2081
    
----
commit 1db426be73f572aec2041cb1a9da6ad49425f392
Author: Gordon Tai <gor...@vm5.com>
Date:   2016-06-08T10:46:02Z

    [FLINK-4020] Move shard list querying to open() for Kinesis consumer

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to