[
https://issues.apache.org/jira/browse/FLINK-5547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantin Knauf updated FLINK-5547:
------------------------------------
Labels: (was: auto-closed)
Priority: Not a Priority (was: Minor)
> Move checks for DataSetRel validity into constructor
> ----------------------------------------------------
>
> Key: FLINK-5547
> URL: https://issues.apache.org/jira/browse/FLINK-5547
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / API
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Fabian Hueske
> Priority: Not a Priority
>
> At the moment, most check to verify that a {{DataSetRel}} is valid are done
> in the {{translateToPlan()}} method. These checks are for instance validating
> that a {{DataSetJoin}} has at least one equality predicate.
> Usually, the optimization process (i.e., the translation rules) should take
> care that no plans with invalid operators can be constructed. However, we
> should have these validity checks as an additional safety net which catch
> invalid plans if optimization rules are added or modified.
> These checks should be done in the constructor to ensure that invalid
> operators are identified and not overlooked because this plan alternative was
> more expensive than a valid one.
> This issue is to check all {{DataSetRel}} nodes and move their validity
> checks into the constructor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
