dawidwys commented on a change in pull request #16589:
URL: https://github.com/apache/flink/pull/16589#discussion_r679132412
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1277,10 +1291,14 @@ public final ExecutorService
getAsyncOperationsThreadPool() {
private void notifyCheckpointComplete(long checkpointId) throws Exception {
subtaskCheckpointCoordinator.notifyCheckpointComplete(
checkpointId, operatorChain, this::isRunning);
- if (isRunning && isSynchronousSavepointId(checkpointId)) {
- finishTask();
- // Reset to "notify" the internal synchronous savepoint mailbox
loop.
- resetSynchronousSavepointId(checkpointId, true);
+ if (isRunning) {
+ if (isCurrentSavepointWithoutDrain(checkpointId)) {
+ finishTask();
+ // Reset to "notify" the internal synchronous savepoint
mailbox loop.
+ syncSavepointWithoutDrain = null;
+ } else if (isCurrentSavepointWithDrain(checkpointId)) {
+ savepointCompletedFuture.complete(null);
+ }
Review comment:
Yes, we do: https://issues.apache.org/jira/browse/FLINK-23532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
