pnowojski commented on a change in pull request #16589:
URL: https://github.com/apache/flink/pull/16589#discussion_r679224782
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java
##########
@@ -114,6 +114,8 @@
/** The source reader that does most of the work. */
private SourceReader<OUT, SplitT> sourceReader;
+ private SourceReader<OUT, SplitT> readingReader;
Review comment:
That assumes two things:
1. only `FinishedDataReader` will only be used here
2. `FinishedDataReader` will never be requiring `close()`
both of those assumptions are easy to violate unknowingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
