zentol commented on a change in pull request #16592:
URL: https://github.com/apache/flink/pull/16592#discussion_r679759270



##########
File path: 
flink-filesystems/flink-s3-fs-presto/src/main/resources/META-INF/NOTICE
##########
@@ -6,32 +6,38 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
+- aopalliance:aopalliance:1.0

Review comment:
       this is not apache licensed, but Public Domain.

##########
File path: flink-filesystems/flink-s3-fs-presto/pom.xml
##########
@@ -33,7 +33,7 @@ under the License.
        <packaging>jar</packaging>
 
        <properties>
-               <presto.version>0.187</presto.version>
+               <presto.version>0.257</presto.version>

Review comment:
       Is it actually required to bump presto itself? If bumping the aws 
dependencies is sufficient for s3-fs-hadoop, why not presto?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to