zentol commented on pull request #16592: URL: https://github.com/apache/flink/pull/16592#issuecomment-889832167
> You only tested for compilation, but not the functionality itself, right? Correct. But hey, in practice my review would also be limited to that. My impressions was that you wanted to do another functionality check. > I'd like to avoid starting over I was only throwing an idea around. Because _if_ there are no disagreements on whether it is reasonable, then I think this would be a good opportunity to do it; we are already changing the dependency tree and need to do functional checks. In any case, I think the current set of inclusions/exclusions is fine. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
