akalash commented on a change in pull request #16628:
URL: https://github.com/apache/flink/pull/16628#discussion_r679969509
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -307,6 +307,12 @@ private void notifyCreditAvailable() throws IOException {
partitionRequestClient.notifyCreditAvailable(this);
}
+ private void notifyNewBufferSize() throws IOException {
+ checkPartitionRequestQueueInitialized();
+
+ partitionRequestClient.notifyNewBufferSize(this);
Review comment:
Passing the `currentBufferSize` right away instead of using the
`AtomicLong` is a good idea but unfortunately, it is not possible to get rid of
`this` from here because we create `ClientOutboundMessage` which requires the
channel. But we indeed can pass the two arguments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
