wsry commented on a change in pull request #16465:
URL: https://github.com/apache/flink/pull/16465#discussion_r680450890
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
##########
@@ -837,6 +841,18 @@ public void notifyNotEnoughResourcesAvailable(
}
}
+ @Override
+ public CompletableFuture<?>
stopTrackingPartitions(Collection<ResultPartitionID> partitionIDS) {
+ CompletableFuture<?> future = new CompletableFuture<>();
+ try {
+ partitionTracker.stopTrackingAndReleasePartitions(partitionIDS);
Review comment:
I also considered the the potential local resource but we do not have an
existing method to do that so I chose the stopTrackingAndReleasePartitions
method. Generally, release an already release external partition is not a big
issue, I think one choice is to describe this behavior in the java doc. Another
choice is to add such a method like
stopTrackingPartitionsAndReleaseLocalResources. Which one do you prefer? Or is
there any better choice?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
