[
https://issues.apache.org/jira/browse/FLINK-3763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15322517#comment-15322517
]
Arnaud Linz commented on FLINK-3763:
------------------------------------
This comment is probably too late, but I have a problem with :
while (running) {
QueueingConsumer.Delivery delivery = consumer.nextDelivery();
and
public void cancel() {
running = false;
}
If no element ever comes in the queue, nextDelivery may wait forever as no
timeout is provided, so the while(running) is never executed, and the cancel()
method does nothing. It prevents us from properly cancelling such sources,
forcing the user to kill the yarn application to be able to bypass the forever
"cancelling" state of the flink workflow.
> RabbitMQ Source/Sink standardize connection parameters
> ------------------------------------------------------
>
> Key: FLINK-3763
> URL: https://issues.apache.org/jira/browse/FLINK-3763
> Project: Flink
> Issue Type: Improvement
> Components: Streaming Connectors
> Affects Versions: 1.0.1
> Reporter: Robert Batts
> Assignee: Subhankar Biswas
> Fix For: 1.1.0
>
>
> The RabbitMQ source and sink should have the same capabilities in terms of
> establishing a connection, currently the sink is lacking connection
> parameters that are available on the source. Additionally, VirtualHost should
> be an offered parameter for multi-tenant RabbitMQ clusters (if not specified
> it goes to the vhost '/').
> Connection Parameters
> ===================
> - Host - Offered on both
> - Port - Source only
> - Virtual Host - Neither
> - User - Source only
> - Password - Source only
> Additionally, it might be worth offer the URI as a valid constructor because
> that would offer all 5 of the above parameters in a single String.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
