StephanEwen commented on a change in pull request #246:
URL: https://github.com/apache/flink-statefun/pull/246#discussion_r680856032
##########
File path: pom.xml
##########
@@ -307,6 +308,58 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <!--surefire for unit tests and integration tests-->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.1</version>
+ <configuration>
+ <trimStackTrace>false</trimStackTrace>
+ <systemPropertyVariables>
+ <forkNumber>0${surefire.forkNumber}</forkNumber>
+
<checkpointing.randomization>true</checkpointing.randomization>
+ <!-- on, unset, or random -->
+
<checkpointing.changelog>unset</checkpointing.changelog>
Review comment:
Same as above
##########
File path: pom.xml
##########
@@ -307,6 +308,58 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <!--surefire for unit tests and integration tests-->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.1</version>
+ <configuration>
+ <trimStackTrace>false</trimStackTrace>
+ <systemPropertyVariables>
+ <forkNumber>0${surefire.forkNumber}</forkNumber>
+
<checkpointing.randomization>true</checkpointing.randomization>
Review comment:
This is Flink-specific, not needed in statefun.
##########
File path: pom.xml
##########
@@ -307,6 +308,58 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <!--surefire for unit tests and integration tests-->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.1</version>
+ <configuration>
+ <trimStackTrace>false</trimStackTrace>
+ <systemPropertyVariables>
+ <forkNumber>0${surefire.forkNumber}</forkNumber>
+
<checkpointing.randomization>true</checkpointing.randomization>
+ <!-- on, unset, or random -->
+
<checkpointing.changelog>unset</checkpointing.changelog>
+ <project.basedir>${project.basedir}</project.basedir>
+ <!--suppress MavenModelInspection -->
+
<test.randomization.seed>${test.randomization.seed}</test.randomization.seed>
+ </systemPropertyVariables>
+ <argLine>-Xms256m -Xmx2048m
-Dmvn.forkNumber=${surefire.forkNumber} -XX:+UseG1GC</argLine>
+ </configuration>
+ <executions>
+ <!--execute all the unit tests-->
+ <execution>
+ <id>default-test</id>
+ <phase>test</phase>
+ <goals>
+ <goal>test</goal>
+ </goals>
+ <configuration>
+ <includes>
+ <include>${test.unit.pattern}</include>
+ </includes>
+ </configuration>
+ </execution>
Review comment:
Maybe add `<reuseForks>true</reuseForks>` here to make it explicit.
##########
File path: pom.xml
##########
@@ -307,6 +308,58 @@ under the License.
</execution>
</executions>
</plugin>
+
+ <!--surefire for unit tests and integration tests-->
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>2.22.1</version>
+ <configuration>
+ <trimStackTrace>false</trimStackTrace>
+ <systemPropertyVariables>
+ <forkNumber>0${surefire.forkNumber}</forkNumber>
+
<checkpointing.randomization>true</checkpointing.randomization>
+ <!-- on, unset, or random -->
+
<checkpointing.changelog>unset</checkpointing.changelog>
+ <project.basedir>${project.basedir}</project.basedir>
+ <!--suppress MavenModelInspection -->
+
<test.randomization.seed>${test.randomization.seed}</test.randomization.seed>
Review comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
