nicoweidner commented on a change in pull request #16654:
URL: https://github.com/apache/flink/pull/16654#discussion_r680911981
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/webmonitor/threadinfo/JobVertexThreadInfoTrackerTest.java
##########
@@ -169,20 +168,32 @@ public void testCachedStatsUpdatedAfterRefreshInterval()
throws Exception {
/** Tests that cached results are removed within the cleanup interval. */
@Test
public void testCachedStatsCleanedAfterCleanupInterval() throws Exception {
Review comment:
I found it borderline because:
- On the one hand, we allow configuring the `cleanupInterval`
- On the other hand, we basically just hand it over to the guava Cache
Would you prefer invalidating the entry manually for this test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
