pnowojski commented on a change in pull request #16628:
URL: https://github.com/apache/flink/pull/16628#discussion_r681177509
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/IndexedInputGate.java
##########
@@ -64,4 +64,8 @@ public void blockConsumption(InputChannelInfo channelInfo) {
public void convertToPriorityEvent(int channelIndex, int sequenceNumber)
throws IOException {
getChannel(channelIndex).convertToPriorityEvent(sequenceNumber);
}
+
+ public abstract int getBuffersInUseCount();
Review comment:
On a second thought, I think this should be not worse compared to the
`OutputFlusher`, which by default is executed every `100ms`. I would start with
this, and if it turns out a problem, we can optimise it in the future.
Also we should check if it indeed solves the data skew case.
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/throughput/ThroughputCalculator.java
##########
@@ -71,4 +71,8 @@ public long calculateThroughput() {
return lastThroughput;
}
+
+ public long lastThroughput() {
Review comment:
nit: `getLastThroughput()`. Is this being used anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
